Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex174B Backport the most recent version of Run3 geometries of 2021 and 2023 from #43418 and earlier pull requests for GE21 and HCAL #43421

Closed
wants to merge 1 commit into from

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport the most recent version of Run3 geometries of 2021 and 2023 from #43418 and earlier pull requests for GE21 and HCAL

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport xml, cfi, cff files from #43418 and other earlier pull requests

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/ForwardCommonData (geometry)
  • Geometry/ForwardSimData (geometry)
  • Geometry/HcalCommonData (geometry)
  • Geometry/MuonCommonData (geometry)

@Dr15Jones, @mdhildreth, @cmsbuild, @srimanob, @civanch, @makortel, @bsunanda can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @watson-ij, @missirol, @vargasa, @slomeo, @ptcox, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@civanch
Copy link
Contributor

civanch commented Nov 28, 2023

@bsunanda , please, update the title in order to have explicitly "ZDC" in the title to avoid confusions.

@antoniovilela
Copy link
Contributor

@cms-sw/simulation-l2 @cms-sw/geometry-l2
@cms-sw/ppd-l2 @cms-sw/reconstruction-l2 @cms-sw/orp-l2
Vladimir, Sunanda,
PPD and reconstruction may comment, but it seems that the best is to disentangle what is needed for ZDC from the rest.
If there is something else needed in the GEN-SIM release (we assume it is 13_0_X) for the HI MC, than this should be further disentangled from the rest that is included in this PR.
Thanks.

@antoniovilela
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Nov 28, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e5393/36126/summary.html
COMMIT: bb9cdaf
CMSSW: CMSSW_13_2_X_2023-11-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43421/36126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 2909 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 6172
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3192591
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@civanch
Copy link
Contributor

civanch commented Nov 28, 2023

@antoniovilela , geometry description update is not the same thing as code update. Code may be updated via small increments, geometry include several components: xml description for subdetectors, a set of geometry scenarios, pilots for DB record, new GT. It will bring a mess and will require much more efforts and time.

@bsunanda , there are differences in WF 11634.911, is it expected?


[11634.911](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_2_X_2023-11-28-1100+9e5393/59998/11634.911_TTbar_14TeV+2021_DD4hep)

@makortel
Copy link
Contributor

there are differences in WF 11634.911, is it expected?

Could they be related to #35109?

@antoniovilela
Copy link
Contributor

@antoniovilela , geometry description update is not the same thing as code update. Code may be updated via small increments, geometry include several components: xml description for subdetectors, a set of geometry scenarios, pilots for DB record, new GT. It will bring a mess and will require much more efforts and time.

@bsunanda , there are differences in WF 11634.911, is it expected?

11634.911

@cms-sw/ppd-l2 @mandrenguyen @cms-sw/alca-l2 @cms-sw/orp-l2
Please discuss with PPD and HI experts in order to define a strategy that is clear to everyone, does not create incompatibilities with current production cycles, and is fully validated.
Once everyone is on the same page, we proceed.
Thanks.

@malbouis
Copy link
Contributor

Hi @antoniovilela , thanks for holding this PR. PPD would prefer if nothing other than the ZDC geometry is backported. And even for the ZDC geometry, the backport should only be done in case it is deemed essential for the Heavy Ion MC production. We are discussing it with the HI coordinators.

@bsunanda
Copy link
Contributor Author

Close this in favour of #43443

@bsunanda bsunanda closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants