-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex174B Backport the most recent version of Run3 geometries of 2021 and 2023 from #43418 and earlier pull requests for GE21 and HCAL #43421
Conversation
…from cms-sw#43418 and earlier pull requests for GE21 and HCAL
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_2_X. It involves the following packages:
@Dr15Jones, @mdhildreth, @cmsbuild, @srimanob, @civanch, @makortel, @bsunanda can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
@bsunanda , please, update the title in order to have explicitly "ZDC" in the title to avoid confusions. |
@cms-sw/simulation-l2 @cms-sw/geometry-l2 |
hold |
Pull request has been put on hold by @antoniovilela |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e5393/36126/summary.html Comparison SummarySummary:
|
@antoniovilela , geometry description update is not the same thing as code update. Code may be updated via small increments, geometry include several components: xml description for subdetectors, a set of geometry scenarios, pilots for DB record, new GT. It will bring a mess and will require much more efforts and time. @bsunanda , there are differences in WF 11634.911, is it expected? |
Could they be related to #35109? |
@cms-sw/ppd-l2 @mandrenguyen @cms-sw/alca-l2 @cms-sw/orp-l2 |
Hi @antoniovilela , thanks for holding this PR. PPD would prefer if nothing other than the ZDC geometry is backported. And even for the ZDC geometry, the backport should only be done in case it is deemed essential for the Heavy Ion MC production. We are discussing it with the HI coordinators. |
Close this in favour of #43443 |
PR description:
Backport the most recent version of Run3 geometries of 2021 and 2023 from #43418 and earlier pull requests for GE21 and HCAL
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport xml, cfi, cff files from #43418 and other earlier pull requests